Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decode all CAs in secret for activator #13877

Open
nak3 opened this issue Apr 13, 2023 · 0 comments
Open

Decode all CAs in secret for activator #13877

nak3 opened this issue Apr 13, 2023 · 0 comments
Labels
kind/feature Well-understood/specified features, ready for coding. triage/accepted Issues which should be fixed (post-triage)

Comments

@nak3
Copy link
Contributor

nak3 commented Apr 13, 2023

As per #13854 (comment)

Currently we decod only one CA in the top of the secret.

serving/pkg/activator/certificate/cache.go

Line 96 in 018c7f8

block, _ := pem.Decode(secret.Data[certificates.CaCertName])

It should be fine at this moment, but it should decode all CAs in the secret especially if we support BYO CA cert.
@nak3 nak3 added the kind/feature Well-understood/specified features, ready for coding. label Apr 13, 2023
@ReToCode ReToCode added the triage/accepted Issues which should be fixed (post-triage) label Apr 14, 2023
@ReToCode ReToCode mentioned this issue Sep 20, 2023
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Well-understood/specified features, ready for coding. triage/accepted Issues which should be fixed (post-triage)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nak3 @ReToCode