We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
svc.cluster.local
Rather than hardcode the default domain I think we should use the cluster's domain from the knative/pkg helper
serving/pkg/reconciler/route/config/domain.go
Lines 34 to 36 in ea2a6c8
and use
network.GetClusterDomainName()
https://github.com/knative/pkg/blob/db8a35330281c41c7e8e90df6059c23a36af0643/network/domain.go#L46
I don't think we catch this in our e2e tests because we use a fake domain name - https://github.com/knative/serving/blob/ea2a6c8c6166d27b3251469400efed33125cac15/test/config/ytt/core/overlay-config-domain.yaml
FYI @psschwei @nak3
The text was updated successfully, but these errors were encountered:
/assign @kauana
Sorry, something went wrong.
kauana
Successfully merging a pull request may close this issue.
Rather than hardcode the default domain I think we should use the cluster's domain from the knative/pkg helper
serving/pkg/reconciler/route/config/domain.go
Lines 34 to 36 in ea2a6c8
and use
https://github.com/knative/pkg/blob/db8a35330281c41c7e8e90df6059c23a36af0643/network/domain.go#L46
I don't think we catch this in our e2e tests because we use a fake domain name - https://github.com/knative/serving/blob/ea2a6c8c6166d27b3251469400efed33125cac15/test/config/ytt/core/overlay-config-domain.yaml
FYI @psschwei @nak3
The text was updated successfully, but these errors were encountered: