Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DefaultDomain should be the cluster's domain and not hardcoded to svc.cluster.local #13955

Closed
dprotaso opened this issue May 6, 2023 · 1 comment · Fixed by #13964
Closed
Assignees
Milestone

Comments

@dprotaso
Copy link
Member

dprotaso commented May 6, 2023

Rather than hardcode the default domain I think we should use the cluster's domain from the knative/pkg helper

// DefaultDomain holds the domain that Route's live under by default
// when no label selector-based options apply.
DefaultDomain = "svc.cluster.local"

and use

network.GetClusterDomainName()

https://github.com/knative/pkg/blob/db8a35330281c41c7e8e90df6059c23a36af0643/network/domain.go#L46

I don't think we catch this in our e2e tests because we use a fake domain name - https://github.com/knative/serving/blob/ea2a6c8c6166d27b3251469400efed33125cac15/test/config/ytt/core/overlay-config-domain.yaml

FYI @psschwei @nak3

@kauana
Copy link
Member

kauana commented May 7, 2023

/assign @kauana

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants