Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prow with mesh mode does not test with Istio mesh profile #14182

Closed
nak3 opened this issue Jul 19, 2023 · 2 comments · Fixed by #14276 or #14296
Closed

Prow with mesh mode does not test with Istio mesh profile #14182

nak3 opened this issue Jul 19, 2023 · 2 comments · Fixed by #14276 or #14296
Assignees
Labels
area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features kind/bug Categorizes issue or PR as related to a bug. triage/accepted Issues which should be fixed (post-triage)
Milestone

Comments

@nak3
Copy link
Contributor

nak3 commented Jul 19, 2023

In what area(s)?

/area networking
/area test-and-release

What version of Knative?

  • HEAD

Expected Behavior

  • prow tests with istio-ci-mesh/istio.yaml profile instead of istio-ci-no-mesh/istio.yaml.

Actual Behavior

  • prow mesh test does not use istio-ci-mesh/istio.yaml but istio-ci-no-mesh/istio.yaml.

Steps to Reproduce the Problem

+ ./test/presubmit-tests.sh --run-test './test/e2e-tests.sh --istio-version latest --mesh' --run-test './test/e2e-auto-tls-tests.sh --istio-version latest --mesh'

but it uses istio-ci-no-mesh profile.

Got NET_ISTIO_COMMIT from /home/prow/go/src/knative.dev/serving/third_party/istio-latest/net-istio.yaml: ae9f4ffa632ccc62be2022ab0b1e66983e5c62d6
--2023-07-19 00:46:35--  https://raw.githubusercontent.com/knative-sandbox/net-istio/ae9f4ffa632ccc62be2022ab0b1e66983e5c62d6/third_party/istio-latest/istio-ci-no-mesh/istio.yaml
@nak3 nak3 added the kind/bug Categorizes issue or PR as related to a bug. label Jul 19, 2023
@knative-prow knative-prow bot added area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features labels Jul 19, 2023
@ReToCode ReToCode added the triage/accepted Issues which should be fixed (post-triage) label Jul 24, 2023
@dprotaso dprotaso added this to the v1.12.0 milestone Aug 2, 2023
@dprotaso
Copy link
Member

Some backstory.

We changed our parsing logic because of #12788 - afterwards we only 'parse' the flags once.

But the second time the script is invoked we have export SOMEVAR=0 which is resetting some variables. In theory marking the vars as readonly should prevent that but this doesn't seem to work in child processes.

I think it may be simpler to just dedupe flags in our knative/hack script

@dprotaso
Copy link
Member

/assign @dprotaso

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features kind/bug Categorizes issue or PR as related to a bug. triage/accepted Issues which should be fixed (post-triage)
Projects
3 participants