Images used for verifying e2e tests should be built from source

[srinivashegde86]

/area test-and-release
/kind bug
/kind dev

Expected Behavior

We should be building and pushing the image used by the e2e tests from source. So, whenever someone makes changes, we can upload the new image and test against that.

Actual Behavior

When engineers update one of the e2e tests that need an be build into a docker image like tha hello world or the autoscaler tests, they need to depend on one of the test/OWNERS to push the image to our e2e tests docker repo to start testing their changes. Else, prow will only test using the old image and fail continously.

Sample for source to url -> https://github.com/knative/docs/tree/master/serving/samples/source-to-url-go

[srinivashegde86]

I think we can accomplish this with ko.

ko publish github.com/knative/serving/test/e2e/test_images/autoscale publishes the to KO_DOCKER_REPO/github.com/knative/serving/test/e2e/test_images/autoscale

[srinivashegde86]

Tried using this, but is failing with permission error when uploading images when I run the e2e-tests.sh script locally.

[adrcunha]

It should work with e2e-tests.sh if you publish to DOCKER_REPO_OVERRIDE, because it's guaranteed that the current user has (exclusive) write access to it.

[mattmoor]

I believe we call ./test/upload-images.sh in our e2e tests, so what is missing?

[adrcunha]

Nothing, this is a dupe of #1720.