Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial queue-proxy websocket errors are confusing. #2951

Closed
markusthoemmes opened this issue Jan 21, 2019 · 2 comments
Closed

Initial queue-proxy websocket errors are confusing. #2951

markusthoemmes opened this issue Jan 21, 2019 · 2 comments
Assignees
Labels
area/autoscale area/networking kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@markusthoemmes
Copy link
Contributor

Expected Behavior

The queue-proxy does not report any errors after startup if it can successfully connect to the autoscaler via a websocket connection.

Actual Behavior

The queue-proxy almost always reports one or two failures because an event was tried to be sent before an initial connection was created.

Steps to Reproduce the Problem

  1. Deploy any application.
  2. Check the queue-proxy logs for "connection has not yet been established"

Additional Info

To mitigate this, we could only start reporting these kinds of errors a certain time after startup. 10 seconds should suffice in this case I think.

@knative-prow-robot knative-prow-robot added area/autoscale area/networking kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/good-first-issue labels Jan 21, 2019
@markusthoemmes
Copy link
Contributor Author

/assign

@owenthereal
Copy link

I updated on #2892 (comment) that the readiness probe for queue-proxy failed and caused the pod to be terminated. Not sure if it's related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/autoscale area/networking kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

No branches or pull requests

3 participants