Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making a large team a code owner spams that team with review requests #297

Closed
grantr opened this issue Mar 6, 2018 · 4 comments
Closed

Making a large team a code owner spams that team with review requests #297

grantr opened this issue Mar 6, 2018 · 4 comments

Comments

@grantr
Copy link
Contributor

grantr commented Mar 6, 2018

The Elafros Writers team (roughly 50 people) is an owner of the docs folder, which means every PR that touches docs sends a review request to everyone on that team. Team owners should be smaller to reduce notification noise.
@steren
Copy link
Contributor

steren commented Mar 12, 2018

+1, this prevents me from identifying notifications I should really act on

@mattmoor
Copy link
Member

@grantr is is just docs?

@grantr
Copy link
Contributor Author

grantr commented Mar 22, 2018

This will be fixed by workflow changes after #344 is merged.

@grantr grantr closed this as completed Mar 22, 2018
@steren
Copy link
Contributor

steren commented May 8, 2018

I seem to still be receiving all Pull Request of this repo.

I am currently 'Not watching' the elafros repo.
Is there a setting I should change? Is it because I am part of a reviewer team?

@grantr grantr mentioned this issue May 8, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@grantr @steren @mattmoor