Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve the review process overhead #651

Closed
mattmoor opened this issue Apr 13, 2018 · 3 comments
Closed

Resolve the review process overhead #651

mattmoor opened this issue Apr 13, 2018 · 3 comments
Labels
area/test-and-release It flags unit/e2e/conformance/perf test issues for product features

Comments

@mattmoor
Copy link
Member

Expected Behavior

As a reviewer, I should be able to approve a change with a single action, one of:

  1. GitHub review
  2. /lgtm and/or /approve comment

Actual Behavior

Our concoction of process that straddles Prow (OWNERS) and Github (CODEOWNERS) features means we have to do 2-3 of these things (possibly from multiple reviewers) for tide to merge things.

Maybe I'm "holding it wrong", or we're using Prow incorrectly, but I'd like to streamline this process so it's crystal clear what reviewers need to do to bless a PR.

cc @adrcunha @fejta @cjwagner for suggestions.

@mattmoor mattmoor added the area/test-and-release It flags unit/e2e/conformance/perf test issues for product features label Apr 13, 2018
@mattmoor
Copy link
Member Author

@vaikas-google pointed me at this

@mattmoor mattmoor added this to the M4 milestone Apr 13, 2018
@adrcunha
Copy link
Contributor

There's a discussion about this in #543. Grant wrote an interesting analysis and possible compromise given the restrictions. I don't have any strong opinion about this.

@mattmoor
Copy link
Member Author

Great thanks. let's track this there, sorry for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test-and-release It flags unit/e2e/conformance/perf test issues for product features
Projects
None yet
Development

No branches or pull requests

2 participants