You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As a reviewer, I should be able to approve a change with a single action, one of:
GitHub review
/lgtm and/or /approve comment
Actual Behavior
Our concoction of process that straddles Prow (OWNERS) and Github (CODEOWNERS) features means we have to do 2-3 of these things (possibly from multiple reviewers) for tide to merge things.
Maybe I'm "holding it wrong", or we're using Prow incorrectly, but I'd like to streamline this process so it's crystal clear what reviewers need to do to bless a PR.
There's a discussion about this in #543. Grant wrote an interesting analysis and possible compromise given the restrictions. I don't have any strong opinion about this.
Expected Behavior
As a reviewer, I should be able to approve a change with a single action, one of:
/lgtm
and/or/approve
commentActual Behavior
Our concoction of process that straddles Prow (OWNERS) and Github (CODEOWNERS) features means we have to do 2-3 of these things (possibly from multiple reviewers) for
tide
to merge things.Maybe I'm "holding it wrong", or we're using Prow incorrectly, but I'd like to streamline this process so it's crystal clear what reviewers need to do to bless a PR.
cc @adrcunha @fejta @cjwagner for suggestions.
The text was updated successfully, but these errors were encountered: