Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding 401 to the explicitly defined codes #108

Closed
creydr opened this issue Sep 25, 2023 · 2 comments · Fixed by #114
Closed

Adding 401 to the explicitly defined codes #108

creydr opened this issue Sep 25, 2023 · 2 comments · Fixed by #114
Assignees
@xiangpingjiang
Labels
good first issue Good for newcomers help wanted Extra attention is needed triage/accepted Issues which should be fixed (post-triage)

Comments

@creydr
Copy link
Member

creydr commented Sep 25, 2023

As we might reject received events in case of invalid/missing authentication and return a 401, we should update the spec to include this HTTP status code.

References:
@creydr creydr moved this to 🔖 Ready in Eventing Sender Identity Sep 25, 2023
@creydr creydr added the help wanted Extra attention is needed label Sep 25, 2023
@creydr creydr added the good first issue Good for newcomers label Dec 4, 2023
@Leo6Leo
Copy link
Member

Leo6Leo commented Jan 5, 2024

/triage accepted

@knative-prow knative-prow bot added the triage/accepted Issues which should be fixed (post-triage) label Jan 5, 2024
@xiangpingjiang
Copy link
Contributor

/assign

@xiangpingjiang xiangpingjiang mentioned this issue Jan 12, 2024
Merged
@github-project-automation github-project-automation bot moved this from 🔖 Ready to ✅ Done in Eventing Sender Identity Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xiangpingjiang xiangpingjiang

Labels
good first issue Good for newcomers help wanted Extra attention is needed triage/accepted Issues which should be fixed (post-triage)
Projects
Eventing Sender Identity
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add 401 to the explicitly defined codes xiangpingjiang/specs
3 participants
@creydr @Leo6Leo @xiangpingjiang