warning: comparison of integer expressions of different signedness

[SteveRMann]

I know it's "just a warning", but it is so easy to fix.

Complete warning:

C:\Users\steve\Documents\Arduino\libraries\PubSubClient\src\PubSubClient.cpp:523:16: warning: comparison of integer expressions of different signedness: 'unsigned int' and 'int' [-Wsign-compare]
  523 |     return (rc == expectedLength);
      |             ~~~^~~~~~~~~~~~~~~~~

Solution:
In PubSubClient.cpp, at line 481, change unsigned int rc to uint16_t rc

[m1cje]

unsigned int rc is a 32 bit value, changing it to uint16_t may have unforeseen consequences, better to change expectedLength to be unsigned as it's unlikely to ever be negative

[stefan123t]

The suggested simple fix by @m1cje to declare unsigned int expectedLength in

pubsubclient/src/PubSubClient.cpp

Line 487 in 2d228f2

int expectedLength;

is obviously valid as:

pubsubclient/src/PubSubClient.cpp

Lines 521 to 523 in 2d228f2

	expectedLength = 1 + llen + 2 + tlen + plength;
	return (rc == expectedLength);

All of llen, tlen and plength are uint8/16_t or unsigned int either. Hence expectedLength cannot become negative at all.

Thanks for providing and maintaining this library in the first place!