Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Being able to set different colors based on the word being drawn #20

Closed
TDC-mobstation opened this issue Dec 19, 2022 · 3 comments · Fixed by #21
Closed

Being able to set different colors based on the word being drawn #20

TDC-mobstation opened this issue Dec 19, 2022 · 3 comments · Fixed by #21
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@TDC-mobstation
Copy link

Hello!
What do you think of the idea of being able to return different results from the Colorizer based on the word being drawn? The use case in mind is that for certain word cloud we'd like to be able to provide a list of words that should be highlighted (eg drawn in another color than the base color).

We've found no way of doing this with how the library looks currently (please correct us if we've missed anything). One idea would perhaps be that the GetColorAsHex would receive the word being drawn and you could handle the return of the color in the Colorizer as you do currently. Any thoughts on this?

@jjonescz
Copy link
Member

Yes, I think that's a good idea. Should not be difficult to implement, so I can work on it later this week. Or if you want to send a pull request, I will gladly accept it.

Note that an external contributor also previously implemented the colorization in #4.

@jjonescz jjonescz added enhancement New feature or request good first issue Good for newcomers labels Dec 19, 2022
@jjonescz
Copy link
Member

🎉 This has been added in the latest version 1.3.0 (available on NuGet).

Thanks for the idea. Hope this helps for your use case. If not, please let me know.

@TDC-mobstation
Copy link
Author

That works excellent, what a nice Christmas gift !🥳

Thanks a lot for this =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants