Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TradeOgreAdapters.adaptCurrencyPair() build a wrong CurrencyPair #4870

Open
francitoshi opened this issue May 7, 2024 · 2 comments
Open

TradeOgreAdapters.adaptCurrencyPair() build a wrong CurrencyPair #4870

francitoshi opened this issue May 7, 2024 · 2 comments

Comments

@francitoshi
Copy link

class "TradeOgreAdapters" has the method "adaptCurrencyPair" with

return currencyPair.counter.toString() + "-" + currencyPair.base.toString();

but shoud be

return currencyPair.base.toString() + "-" + currencyPair.counter.toString();

This bug prevents applications from placing an order, with this change the problem it's solved.
@gewure
Copy link

gewure commented May 15, 2024

please create a PR @francitoshi !

@bigscoop
Copy link
Contributor

it is this one #4871

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bigscoop @gewure @francitoshi