Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance difference of the precompiled executable from github #263

Closed
aannleax opened this issue Jun 12, 2023 · 4 comments · Fixed by #273
Closed

Performance difference of the precompiled executable from github #263

aannleax opened this issue Jun 12, 2023 · 4 comments · Fixed by #273
Assignees
Labels
infrastructure Build/CI/packaging infrastructure
Milestone

Comments

@aannleax
Copy link
Member

On my system, at least for the deep-100 use case, the precompiled executable from github (Version v0.1.0) is a lot slower than if I were to compile the executable myself.

Compiled v0.1.0:
Reasoning completed in 2018ms. Derived 20202 facts.
   Loading input:   1797ms
   Reasoning:        220ms

Precompiled v0.1.0:
Reasoning completed in 4122ms. Derived 20202 facts.
   Loading input:   3847ms
   Reasoning:        274ms

This needs some investigation.

@aannleax aannleax added the infrastructure Build/CI/packaging infrastructure label Jun 12, 2023
@aannleax aannleax added this to the Release 0.2.0 milestone Jun 12, 2023
@aannleax aannleax added this to nemo Jun 12, 2023
@github-project-automation github-project-automation bot moved this to Todo in nemo Jun 12, 2023
@mmarx
Copy link
Member

mmarx commented Jun 12, 2023

This is most likely because the action builds a static binary, linked against musl, whereas by default, you will get a binary that links dynamically against glibc. In particular, this means it uses another memory allocator, which might not be as efficient. Likely, the way to fix this is by replacing the action (since it doesn't support linking against glibc).

@mmarx
Copy link
Member

mmarx commented Jun 12, 2023

We probably just want to use something like htis: https://github.com/BurntSushi/ripgrep/tree/master/.github/workflows/release.yml

@mkroetzsch
Copy link
Member

Does this affect all binaries or just the Linux builds?

@mmarx
Copy link
Member

mmarx commented Jun 16, 2023

Just the linux builds, but that's the only one we're building automatically anyway right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Build/CI/packaging infrastructure
Projects
Archived in project
3 participants