Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insufficient unit test coverage of logical layer #97

Open
aannleax opened this issue Jan 13, 2023 · 1 comment
Open

Insufficient unit test coverage of logical layer #97

aannleax opened this issue Jan 13, 2023 · 1 comment
Assignees
@aannleax
Labels
enhancement New feature or request technical-debt Refactoring for an implementation that was good enough at the time tests Test related issues and pull requests

Comments

@aannleax
Copy link
Member

After the refactoring, no unit tests are left on the logical layer. Although the reasoner seems to work in out benchmarks, testing all of the individual functions as well as a few integration tests would be nice.
@aannleax aannleax self-assigned this Jan 13, 2023
@mkroetzsch mkroetzsch changed the title Unit tests in logical layer Insufficient unit test coverage of logical layer Jan 27, 2023
@mmarx mmarx added this to nemo Apr 26, 2023
@github-project-automation github-project-automation bot moved this to Todo in nemo Apr 26, 2023
@mmarx mmarx added this to the Beyond the first release milestone Apr 26, 2023
@mmarx mmarx added enhancement New feature or request tests Test related issues and pull requests labels Apr 26, 2023
@monsterkrampe monsterkrampe added the technical-debt Refactoring for an implementation that was good enough at the time label Jul 18, 2023
@monsterkrampe
Copy link
Member

Is this still an issue?
If so, should we schedule it for an upcoming release?

@aannleax aannleax modified the milestones: Release 0.5.0, Release 0.6.0 Mar 27, 2024
@monsterkrampe monsterkrampe removed this from the Release 0.6.0 milestone Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aannleax aannleax

Labels
enhancement New feature or request technical-debt Refactoring for an implementation that was good enough at the time tests Test related issues and pull requests
Projects
nemo
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mmarx @monsterkrampe @aannleax