Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix phantomjs2 compatibility #304

Closed
wingedfox opened this issue Feb 17, 2016 · 5 comments
Closed

Fix phantomjs2 compatibility #304

wingedfox opened this issue Feb 17, 2016 · 5 comments
Assignees
Labels
Status: Approved Is ready to be worked on

Comments

@wingedfox
Copy link

PhantomJS2 has no phantom.args anymore, System.args should be used.

http://phantomjs.org/api/phantom/property/args.html

@knsv
Copy link
Collaborator

knsv commented Feb 18, 2016

Thanks, will take a look.

@agladysh
Copy link

+1

@ssbarnea
Copy link

I think that this become a critical issue. npm complains about installing an ancient version of phantomjs and even gives an warning regarding package name change:

npm WARN deprecated phantomjs@2.1.3: Package renamed to phantomjs-prebuilt. Please update 'phantomjs' package references to 'phantomjs-prebuilt'

If you happen to have a newer version installed the problem becomes even bigger.

@ssbarnea
Copy link

Here is something that may worked, but that is clearly not the desired UX

npm uninstall -g --force phantomjs
npm uninstall -g --force phantomjs-prebuild
npm install -g phantomjs@1.9.0-0

Not to say that it did take ages to build, because obviously we were not able to benefit from the prebuild versions.

It still takes 100% of 2 cores of a top i7 (ssd), and after 1.5 hours it did not finish yet!

@knsv knsv self-assigned this Mar 23, 2016
@knsv knsv added the Status: Approved Is ready to be worked on label Mar 23, 2016
knsv added a commit that referenced this issue Mar 23, 2016
@tylerlong
Copy link
Collaborator

We do not use PhantomJS any more. Ref: https://github.com/mermaidjs/mermaid.cli

mgenereu pushed a commit to mgenereu/mermaid that referenced this issue Jun 25, 2022
…yarn/develop/mocha-9.1.0

chore(deps-dev): bump mocha from 9.0.3 to 9.1.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Approved Is ready to be worked on
Projects
None yet
Development

No branches or pull requests

5 participants