Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict while using mermaid along with core-js #512

Closed
jibesh opened this issue Apr 11, 2017 · 4 comments
Closed

Conflict while using mermaid along with core-js #512

jibesh opened this issue Apr 11, 2017 · 4 comments

Comments

@jibesh
Copy link

jibesh commented Apr 11, 2017

Hi,
I am trying to use mermaid with core-js https://github.com/zloirock/core-js and is facing some interference. When using core-js alone, the identifier _ refers to an Object. If I also include mermaid (v7.0.0) along with core-js, the identifier gets overwritten by a Function. The order of inclusion for mermaid does not matter.
The following code snippets depict what I mean.

Only using core-js

<script type="text/javascript" src="https://cdnjs.cloudflare.com/ajax/libs/core-js/2.4.1/core.min.js"></script>
typeof _; // "object"

Using mermaid and core-js

<script type="text/javascript" src="https://cdnjs.cloudflare.com/ajax/libs/mermaid/7.0.0/mermaid.min.js"></script> 
<script type="text/javascript" src="https://cdnjs.cloudflare.com/ajax/libs/core-js/2.4.1/core.min.js"></script> 
typeof _; // "function"

<script type="text/javascript" src="https://cdnjs.cloudflare.com/ajax/libs/core-js/2.4.1/core.min.js"></script> 
<script type="text/javascript" src="https://cdnjs.cloudflare.com/ajax/libs/mermaid/7.0.0/mermaid.min.js"></script> 
typeof _; // "function"
@tylerlong
Copy link
Collaborator

tylerlong commented Apr 11, 2017

I am migrating mermaid to ES6 + webpack. By then there will be simple solution to this problem. Please hold off.

@tylerlong
Copy link
Collaborator

I confirm I can reproduce the issue.

@tylerlong
Copy link
Collaborator

The _ from mermaid is lodash:

image

@tylerlong
Copy link
Collaborator

Fixed.

Try latest version: https://unpkg.com/mermaid@7.0.3/dist/mermaid.min.js

mgenereu pushed a commit to mgenereu/mermaid that referenced this issue Jun 25, 2022
Bumps [@sveltejs/kit](https://github.com/sveltejs/kit/tree/HEAD/packages/kit) from 1.0.0-next.196 to 1.0.0-next.201.
- [Release notes](https://github.com/sveltejs/kit/releases)
- [Changelog](https://github.com/sveltejs/kit/blob/master/packages/kit/CHANGELOG.md)
- [Commits](https://github.com/sveltejs/kit/commits/HEAD/packages/kit)

---
updated-dependencies:
- dependency-name: "@sveltejs/kit"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants