Allow other forms of node selection for init() #135
Conversation
The existing behavior of init will always re-render the whole page, and requires that a chart be classed `mermaid`. This change allows the user to specify: - a DOM Node (as from getQuerySelector) - a DOM NodeList (as from getQuerySelectorAll) - an array of nodes (as from jQuery.find) - a string (to be handed to getQuerySelectorAll)
|
Good idea! Will merge! |
Allow other forms of node selection for init()
|
Could you add this info to the usage information in the gh-pages branch? Edit the md page, I can generate updated html pages once the md file is update. And again, thanks for your effort! |
|
I'm on it... On Tue, Mar 10, 2015 at 3:11 PM, Knut Sveidqvist notifications@github.com
|
|
Oooh, I didn't see the global.init wrapper, so the change probably isn't propagating out to what the user sees as mermaid.init. |
|
Np but you are you are right. :) Do you want to fix the array, if not I can do it. I think the whole handling of arguments to init needs an update. Right now, apart from the array in the global wrapper there is also inconsistent behaviour with handling of the configurations between sequence diagrams, flowcharts and gantt diagrams. |
|
i'll submit a second PR with the API fix, but yeah, that's an issue... |
The existing behavior of init will always re-render the whole page, and requires that a chart be classed
mermaid.This change allows the user to specify:
As suggested in #37.
Again, can add tests if desired.