Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize mermaid #519

Merged
merged 66 commits into from
Apr 17, 2017
Merged

Modernize mermaid #519

merged 66 commits into from
Apr 17, 2017

Conversation

tylerlong
Copy link
Collaborator

@tylerlong tylerlong commented Apr 17, 2017

  1. replace npm with yarn
  2. update all denpendent libraries to latest version except d3
    1. d3 has been updated to version 3.5.17
  3. use JavaScript Standard Style to do ESLint
  4. use webpack instead of browserify
    1. browserify is still used somewhere. We will get rid of it sooner or later
  5. lots of refactoring
  6. mermaidAPI now supports both browser and node
  7. use babel to build JS code

Breaking changes

  1. removed auto generated JS file from dist folder. Because it's not a good idea to put them under version control
  2. some of the gulp scripts might stop working because we are now using webpack + package.json scripts
  3. it might have issues on Windows because I didn't test on windows.
  4. Travis CI build is broken. I don't know why because I can run yarn test on my local computer without problem

How to test

yarn install

yarn build
yarn dist

yarn test

open dist/demo/index.html
node dist/demo/index.js

@knsv
Copy link
Collaborator

knsv commented Apr 17, 2017

Strong effort! Merging knowing of the issues with travis CI. Want to avoid have this large change dangling.

@knsv knsv merged commit 189758c into mermaid-js:master Apr 17, 2017
mgenereu pushed a commit to mgenereu/mermaid that referenced this pull request Jun 25, 2022
Bumps node from 17.1.0 to 17.2.0.

---
updated-dependencies:
- dependency-name: node
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants