Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate code #768

Merged
merged 1 commit into from
Dec 17, 2018
Merged

Remove duplicate code #768

merged 1 commit into from
Dec 17, 2018

Conversation

znxkznxk1030
Copy link
Contributor

@znxkznxk1030 znxkznxk1030 commented Dec 5, 2018

The deleted code is the logic to check if the type is not 'undefined' and assign it to the vertex if it's not undefined.

However, this code does not seem essential because same code exists just above it.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 704

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 54.252%

Totals Coverage Status
Change from base Build 671: -0.03%
Covered Lines: 2050
Relevant Lines: 3755

💛 - Coveralls

@tylerlong tylerlong merged commit b097b8b into mermaid-js:master Dec 17, 2018
mgenereu pushed a commit to mgenereu/mermaid that referenced this pull request Jun 25, 2022
…ctions/develop/github/codeql-action-2

chore(deps): bump github/codeql-action from 1 to 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants