Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

μ (U+03BC) vs. µ (U+00B5) #434

Closed
Urhengulas opened this issue Mar 23, 2021 · 3 comments · Fixed by #522
Closed

μ (U+03BC) vs. µ (U+00B5) #434

Urhengulas opened this issue Mar 23, 2021 · 3 comments · Fixed by #522
Labels
breaking change fix / feature / improvement involves a breaking change and needs to wait until next minor version difficulty: easy Pretty easy to solve good first issue Good for newcomers priority: low Low priority for the Knurling team status: needs PR Issue just needs a Pull Request implementing the changes type: enhancement Enhancement or feature request
Milestone
v0.3.0

Comments

@Urhengulas
Copy link
Member

We are using the micro sign (µ) for the µs display hint (see defmt-book). If a user accidentally uses the greek letter mu (μ) which looks the same on most fonts, they get an not super helpful error: unknown display hint: "μs".

It woud be nice to have an error message more along the lines of

error: unknown display hint: "μs"; did you mean "µs"?
@Urhengulas Urhengulas added type: enhancement Enhancement or feature request priority: low Low priority for the Knurling team status: needs PR Issue just needs a Pull Request implementing the changes difficulty: easy Pretty easy to solve labels Mar 23, 2021
@MathiasKoch
Copy link
Contributor

Why not just use us ?

@japaric
Copy link
Member

japaric commented Mar 23, 2021

Why not just use us ?

I would vote for accepting us (and maybe deprecating / removing the mu version in the future)

@Urhengulas
Copy link
Member Author

Why not just use us ?

Agree!

@Urhengulas Urhengulas added the good first issue Good for newcomers label Mar 23, 2021
@Urhengulas Urhengulas added the breaking change fix / feature / improvement involves a breaking change and needs to wait until next minor version label May 7, 2021
@jonas-schievink jonas-schievink added this to the v0.3.0 milestone Jun 9, 2021
@jonas-schievink jonas-schievink mentioned this issue Jun 29, 2021
Merged
@bors bors bot closed this as completed in c0edd77 Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change fix / feature / improvement involves a breaking change and needs to wait until next minor version difficulty: easy Pretty easy to solve good first issue Good for newcomers priority: low Low priority for the Knurling team status: needs PR Issue just needs a Pull Request implementing the changes type: enhancement Enhancement or feature request
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging a pull request may close this issue.

Replace µs hint with us
4 participants
@jonas-schievink @MathiasKoch @japaric @Urhengulas