Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define an MSRV #819

Closed
MabezDev opened this issue Mar 11, 2024 · 5 comments
Closed

Define an MSRV #819

MabezDev opened this issue Mar 11, 2024 · 5 comments

Comments

@MabezDev
Copy link

The readme states the MSRV is the latest stable Rust, but I think now that defmt is a staple in the embedded-rust ecosystem you should consider picking an MSRV and only bumping when needed (and subsequently bumping the version in a semver compatible way too).

@Urhengulas
Copy link
Member

How is this handled usually? Do we build and test against the latest stable and the MSRV in CI?

subsequently bumping the version in a semver compatible way too

What do you mean by that? Would you consider it a breaking change if the MSRV is bumped?

@MabezDev
Copy link
Author

How is this handled usually? Do we build and test against the latest stable and the MSRV in CI?

Yes.

What do you mean by that? Would you consider it a breaking change if the MSRV is bumped?

There doesn't seem to be a clear answer here, at least upstream Rust hasn't taken a stance. In general though, unless defmt needs to opt in to new features, keeping MSRV as latest STABLE seems a bit silly, especially since defmt is used so widely in the ecosystem.

@thejpster
Copy link

I suspect we'll tie the MSRV to Ferrocene's upstream equivalents.

@rursprung rursprung mentioned this issue Sep 30, 2024
@Urhengulas
Copy link
Member

@jonathanpallant said:

Our effective MSRV is currently Ferrocene 24.05 (Rust 1.76.0) and so we should clarify that in the README.

@Urhengulas
Copy link
Member

Fixed by #871.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants