Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add a flag to set the directory to build/apply from #617

Closed
tstromberg opened this issue Feb 25, 2022 · 4 comments
Closed

feature: Add a flag to set the directory to build/apply from #617

tstromberg opened this issue Feb 25, 2022 · 4 comments

Comments

@tstromberg
Copy link
Contributor

I'd like to run many ko apply commands in parallel, but have run into an issue: ko only applies to the current working directory, and there can be only one current working directory within a process.

This means that a parent process has to fork, change working directory, and fork again to execute ko. This is easy in some languages, but not so easy if you are using bash or xargs to coordinate the work.

Since 4.3BSD, tar has included a similar flag that I would probably mimic:

  -C, --directory=DIR        change to directory DIR

If this sounds good, please let me know and I'll throw a PR your way.

@tstromberg tstromberg changed the title feature: Add a flag to change-directory (similar to tar -C) feature: Add a flag to set the current working directory to build/apply from (similar to tar -C) Feb 25, 2022
@tstromberg tstromberg changed the title feature: Add a flag to set the current working directory to build/apply from (similar to tar -C) feature: Add a flag to set the directory to build/apply from (similar to tar -C) Feb 25, 2022
@tstromberg tstromberg changed the title feature: Add a flag to set the directory to build/apply from (similar to tar -C) feature: Add a flag to set the directory to build/apply from Feb 25, 2022
@imjasonh
Copy link
Member

+1!

See also golang/go#50332

@tstromberg
Copy link
Contributor Author

Excellent news! I've created #619 - PTAL :)

@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

@jonjohnsonjr
Copy link
Collaborator

@tstromberg still want this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants