-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use path-to-regex for express-like mounted routes #14
Comments
I can't think of too many cases where it would be useful, usually you can just do the same thing by rewriting the url to match the mount point, but I think even just concept of mounting being just like the |
this would be useful for nested resources. e.g. you have users that have posts and routes like:
and you wanna have two apps: a users app and a posts app - where the posts app is mounted in the users app. there's no good way to do this currently (i think?) since the posts app would be mounted at |
👍 on this request |
+1 |
1 similar comment
👍 |
I'm also for this! Example: import Koa from 'koa'
import mount from 'koa-mount'
import api from './subapps/api'
import html from './subapps/html'
import logger from './tools/logger'
const app = new Koa();
// api is mounted under api (this is possible)
app.use(mount('/api', api));
// html is mounted at /, but isn't called when the path starts with /api
// this is currently not possible
app.use(mount(/^\/(?!api)/, html);
// shared stuff
app.use(logger);
app.listen(3000); I hope you see the validness of this use-case? There's a workaround i'm currently using, but it is ugly. html.use(function (ctx, next) {
if (/^\/(api)/.test(ctx.url)) { return next(); }
//...
}); But this is becoming very tedious to maintain. It'd be better to have all the paths in one location. |
+1 |
with different baseurl, I need to add all route with this mount method |
interested? path-to-regex does prefix routing. should be backwards compatible. not sure how i want to handle keys though. maybe
(next, keys...)
The text was updated successfully, but these errors were encountered: