-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mounted app.context doesn't get applied to parent app #64
Comments
Having this exact issue. Middleware should be configurable to be hierarchical. |
It's more than just app.context, mounting bypasses all context initialization performed at https://github.com/koajs/koa/blob/master/lib/application.js#L175 Try sending a request over https:// to a mounted app, and checking ctxt.request.secure This module fundamentally breaks Koa, it is incompatible. When mounting Koa applications https://github.com/koajs/mount#mounting-applications, it should use callback() to make sure the correct processing happens (at https://github.com/koajs/mount/blob/master/index.js#L36) |
@jbemmel can you provide a PR? |
Hi Philipp, |
Example:
http://localhost:3000/hello results in
test:hallo
http://localhost:3001/hello results in
test:undefined
The text was updated successfully, but these errors were encountered: