SC2319 - confused warning message when checking $? inside a function

[mgmsam]

Hi all!!

Conducted a test on the site https://www.shellcheck.net
I report that this problem is repeated inside a function:

Here's a snippet or screenshot that shows the problem:

#!/bin/bash
print_codout() {
	RETURN=$?
	printf '%s\n' "$RETURN"
}
[ -f foo ] || print_codout

Here's what shellcheck currently says:

$ shellcheck myscript

Line 3
RETURN=$?
       ^-- SC2319 (warning): This $? refers to a condition, not a command. Assign to a variable to avoid it being overwritten.

Originally posted by @mymegasam in #2544 (comment)

[ThanAngell]

I concur that this appears to be a incorrect warning. I received the same warning in a function being called from an exit trap.

cleanup()
{
  rc=$?
  # do cleanup
  return $rc
}

trap 'cleanup;' exit

running locally with version: 0.9.0

[yozachar]

Happens here too:

#!/bin/bash

if [[ $exit_code -ne 0 ]]; then
    :
else
    exit_code=$?    
fi

Line 25:
    exit_code=$?    
              ^-- [SC2319](https://www.shellcheck.net/wiki/SC2319) (warning): This $? refers to a condition, not a command. Assign to a variable to avoid it being overwritten.

[Hi-Angel]

@mgsmgit was it fixed? I don't seem to see references from commits to this issue…

[mgmsam]

@mgsmgit was it fixed? I don't seem to see references from commits to this issue…
Oh, it's a mistake, I accidentally closed it, I'm sorry.