-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Fairness regularization #674
Labels
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
While investigating a failing test on #671, I notice the following lines in
_FairClassifier
:However the default norm computed from cvxpy is p2 (docs).
Additionally
cp.norm
already sums the values over.My suggestion to clean the API a bit is to:
Finally, the
theta[1:]
should only be valid forfit_intercept=True
, otherwise we should usetheta
"entirely".Am I missing something?
The text was updated successfully, but these errors were encountered: