Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Param to change Output topic #6

Open
austin-InDro opened this issue May 31, 2022 · 0 comments
Open

Feature: Param to change Output topic #6

austin-InDro opened this issue May 31, 2022 · 0 comments

Comments

@austin-InDro
Copy link

austin-InDro commented May 31, 2022

Nice work on this code!

I think it would be nice to have the ouput mux variable in case there is a new node you intergrate into your system that by default wants to publish to cmd_vel. By having your robot driver set to another topic, it would remove the danger of code taking over from your mux. It seems it manually has to be changed on the following line in your src node.

output_topic_pub_ = this->create_publisher<geometry_msgs::msg::Twist>("cmd_vel", 10);

Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant