Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: landing page #3714

Closed
15 of 18 tasks
Tracked by #3311
preschian opened this issue Aug 11, 2022 · 8 comments · Fixed by #3718
Closed
15 of 18 tasks
Tracked by #3311

Refactor: landing page #3714

preschian opened this issue Aug 11, 2022 · 8 comments · Fixed by #3718
Labels
A-refactoring Refactoring stuff, make code more readable, mitigating tech debt chief p2 core functionality, or is affecting 60% of app

Comments

@preschian
Copy link
Member

preschian commented Aug 11, 2022 •
edited
Loading

Refactor components to use vue composition API. To make it easier for review and test, I will make multiple PR based on this list:

trying to refactor from the deepest/low-level component, in summary, carousel components are something like this:

carousel
├── card
│   └── media
│   └── identity
│       └── identity-popover

to avoid losing so much context when reviewing the code, create a separate PR for refactoring to vue compose API. context: #3718 (review)
@preschian preschian added the A-refactoring Refactoring stuff, make code more readable, mitigating tech debt label Aug 11, 2022
@preschian preschian mentioned this issue Aug 11, 2022
Closed
20 tasks
@preschian preschian self-assigned this Aug 11, 2022
@kodabot
Copy link
Collaborator

kodabot commented Aug 11, 2022

ASSIGNED - @preschian 🔒 LOCKED -> Saturday, August 13th 2022, 01:57:14 UTC -> 36 hours

@preschian preschian mentioned this issue Aug 12, 2022
Merged
9 tasks
@kodabot
Copy link
Collaborator

kodabot commented Aug 13, 2022

ASSIGNMENT EXPIRED - @preschian has been unassigned.

@petersopko petersopko linked a pull request Aug 13, 2022 that will close this issue
refactor: move media from rmrk/Media/ to media/ #3718
Merged
9 tasks
@petersopko
Copy link
Contributor

ASSIGNMENT EXPIRED - @preschian has been unassigned.

@preschian you need to link the issues in PR if you want to keep the assignment going past the allocated time :)

@petersopko
Copy link
Contributor

@preschian or should the PR solve this one only partially? perhaps we can extract the part you've done to standalone issue if that's the case?

@preschian
Copy link
Member Author

@preschian or should the PR solve this one only partially? perhaps we can extract the part you've done to standalone issue if that's the case?

oohh I think this is better. Yaps, this is only partial, next parts I will open a new standalone issue and link to this issue 👍

@yangwao yangwao added p2 core functionality, or is affecting 60% of app chief labels Aug 13, 2022
@yangwao yangwao mentioned this issue Aug 16, 2022
Closed
@preschian preschian mentioned this issue Aug 16, 2022
Closed
3 tasks
@roiLeo roiLeo reopened this Aug 16, 2022
@yangwao
Copy link
Member

yangwao commented Aug 18, 2022

lol why it closed even not linked as pr closes 🤔
thanks for reopening 🙌

@roiLeo
Copy link
Contributor

roiLeo commented Aug 18, 2022

lol why it closed even not linked as pr closes

Capture d’écran 2022-08-18 à 11 35 14 AM

linked issue in pr will close

@preschian
Copy link
Member Author

I close this, some components left are tracked here #3950

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-refactoring Refactoring stuff, make code more readable, mitigating tech debt chief p2 core functionality, or is affecting 60% of app
Projects
Roadmap Q3Q4
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: move media from rmrk/Media/ to media/ preschian/nft-gallery
5 participants
@preschian @yangwao @roiLeo @petersopko @kodabot