Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: SearchBar - splitting into smaller components #3883

Open
Tracked by #3311
petersopko opened this issue Aug 30, 2022 · 4 comments · Fixed by #3894
Open
Tracked by #3311

Refactor: SearchBar - splitting into smaller components #3883

petersopko opened this issue Aug 30, 2022 · 4 comments · Fixed by #3894
Labels
$$ ~51-150usd A-refactoring Refactoring stuff, make code more readable, mitigating tech debt A-search related to search components p3 non-core, affecting less than 40%

Comments

@petersopko
Copy link
Contributor

Currently, our search SearchBar.vue is at 909 lines of code (bad, hard to debug etc.)

We'd like to see this split up into smaller components, to give an easily demonstrated example, there are at least three different logical chunks I could see being components:
image

Somebody with previous experience in similar refactor efforts could pick this up, go over the code and find more elegant solution to our current SearchBar.vue implementation.
@petersopko petersopko added $$ ~51-150usd A-search related to search components A-refactoring Refactoring stuff, make code more readable, mitigating tech debt p2 core functionality, or is affecting 60% of app labels Aug 30, 2022
This was referenced Aug 30, 2022
Closed
Closed
@Jarsen136
Copy link
Contributor

👋

@kodabot
Copy link
Collaborator

kodabot commented Aug 30, 2022

ASSIGNED - @Jarsen136 🔒 LOCKED -> Friday, September 2nd 2022, 13:19:56 UTC -> 72 hours

@Jarsen136 Jarsen136 mentioned this issue Sep 1, 2022
Merged
18 tasks
@kodabot
Copy link
Collaborator

kodabot commented Sep 2, 2022

ASSIGNMENT EXPIRED - @Jarsen136 has been unassigned.

@roiLeo
Copy link
Contributor

roiLeo commented Oct 24, 2022

Reopen this since we introduce unused code (row, columns, filters & switch) in Landing & Navbar.
In other words, I would like to use SearchBar component outside Search component

@roiLeo roiLeo reopened this Oct 24, 2022
@roiLeo roiLeo mentioned this issue Nov 16, 2022
Open
@roiLeo roiLeo mentioned this issue Dec 22, 2022
Merged
17 tasks
@yangwao yangwao added p3 non-core, affecting less than 40% and removed p2 core functionality, or is affecting 60% of app labels Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
$$ ~51-150usd A-refactoring Refactoring stuff, make code more readable, mitigating tech debt A-search related to search components p3 non-core, affecting less than 40%
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: search bar component Jarsen136/nft-gallery
5 participants
@yangwao @roiLeo @Jarsen136 @petersopko @kodabot