Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gallery Item Desktop - adjust dark mode #4686

Closed
Tracked by #4231
yangwao opened this issue Jan 13, 2023 · 7 comments
Closed
Tracked by #4231

Gallery Item Desktop - adjust dark mode #4686

yangwao opened this issue Jan 13, 2023 · 7 comments
Labels
$ ~<50usd A-item p2 core functionality, or is affecting 60% of app redesign

Comments

@yangwao
Copy link
Member

yangwao commented Jan 13, 2023 •
edited
Loading

check if dark mode plays well on gallery item detail
@yangwao yangwao mentioned this issue Jan 13, 2023
Closed
7 tasks
@yangwao yangwao added $ ~<50usd p2 core functionality, or is affecting 60% of app A-item redesign labels Jan 13, 2023
@petersopko
Copy link
Contributor

👋

@kodabot
Copy link
Collaborator

kodabot commented Jan 13, 2023

ASSIGNED - @petersopko 🔒 LOCKED -> Sunday, January 15th 2023, 03:07:29 UTC -> 36 hours

@yangwao yangwao mentioned this issue Jan 13, 2023
Closed
@prachi00
Copy link
Member

@petersopko @yangwao @roiLeo can we maybe tackle this by merging #4579 and not add more css in dark.scss?

@petersopko
Copy link
Contributor

please let me know here so I can either start or pass 👀 @yangwao

@kodabot
Copy link
Collaborator

kodabot commented Jan 15, 2023

ASSIGNMENT EXPIRED - @petersopko has been unassigned.

@yangwao
Copy link
Member Author

yangwao commented Jan 17, 2023

please let me know here so I can either start or pass 👀 @yangwao

Let's go with dark mode for gallery item detail, as there are a lot of discrepancies iirc

@prachi00 let's merge your PoC work on your CSS theming proposal, but once we will launch gallery item

@roiLeo
Copy link
Contributor

roiLeo commented Feb 24, 2023

closed as completed

@roiLeo roiLeo closed this as completed Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
$ ~<50usd A-item p2 core functionality, or is affecting 60% of app redesign
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@yangwao @roiLeo @prachi00 @petersopko @kodabot