Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-rendering pages #6284

Open
yangwao opened this issue Jun 19, 2023 · 9 comments
Open

Pre-rendering pages #6284

yangwao opened this issue Jun 19, 2023 · 9 comments
Labels
A-seo-search-socials p3 non-core, affecting less than 40% pre-render

Comments

@yangwao
Copy link
Member

yangwao commented Jun 19, 2023

One of things i think why we are not indexed on google is that our pre-render is not there and in the past we've been using Netlify which has somehow built in pre-render back then

Now I'm researching what we can use for prerendering, found this one

Good Q, if we can have something with CF workers?

To be continued as need wrap my head around

@yangwao yangwao added p1 preventing everyone from using app A-seo-search-socials labels Jun 19, 2023
@preschian
Copy link
Member

preschian commented Jun 20, 2023

btw, I already proposed this poc a long time ago

cf-workers + prerender.io

here are the code https://github.com/preschian/prerender-cf-workers

cf-workers + manual construct prerendering

this is what we are using right now on canary and beta https://github.com/kodadot/workers/blob/main/ssr-opengraph/src/template.tsx

if we want simple methods and have a budget for that, I suggest using prerender.io. but, we need to fix this first kodadot/workers#88. even though we use prerender.io methods, currently our domain in production can't hit our workers as a proxy

@yangwao
Copy link
Member Author

yangwao commented Jun 20, 2023

btw, I already proposed this poc a long time ago

nice, I have must missed it.

have a budget for that, I suggest using prerender.io

would be that startup plan enough? https://prerender.io/pricing/ - prerenders is being triggered on visit I guess?

here are the code preschian/prerender-cf-workers

well, let's go with that one than, happy to give it a shot.

@yangwao
Copy link
Member Author

yangwao commented Jun 21, 2023

@preschian can you briefly describe what is difference between using prerender.io and your manual construct prerendering?

cc pretender pricing https://prerender.io/pricing/

Which features we have and won't have?

@preschian
Copy link
Member

what is difference between

I think the main difference is in terms of simplicity. with manual construct, we need to maintain the content for the selected routes (html/template output for bot)

with prerender.io, the content will be served automatically

@yangwao
Copy link
Member Author

yangwao commented Jun 21, 2023

hmmm, okay, let's do release, we will test and evaluate and maybe can get back in week to this if things will still not work well, moving to p4 till then

@yangwao yangwao added p4 affecting less than 10% of app and removed p1 preventing everyone from using app labels Jun 21, 2023
@preschian
Copy link
Member

hmmm, okay, let's do release, we will test and evaluate and maybe can get back in week to this if things will still not work well, moving to p4 till then

lmk if we want to make this more priority again. since, right now we are fixing seo stuff, I think it should be easier if we use prerender.io

@roiLeo
Copy link
Contributor

roiLeo commented Jun 22, 2023

prerender.io pricing look a bit expensive, and I think we'll definitely overpass free tier plan.

I'll ask a random question but Can this work with Nuxt3 and SSR mode?

@preschian
Copy link
Member

preschian commented Jun 22, 2023

I'll ask a random question but Can this work with Nuxt3 and SSR mode?

this is not a random question btw (good question instead XD). when we use nuxt3 and enable ssr mode we dont need prerendering stuff. so we can drop prerendering worker stuff

nuxt3 uses nitro, and it already supports cloudflare pages https://nitro.unjs.io/deploy/providers/cloudflare#cloudflare-pages

@yangwao
Copy link
Member Author

yangwao commented Jun 23, 2023

lmk if we want to make this more priority again. since, right now we are fixing seo stuff, I think it should be easier if we use prerender.io

okay, let's go with it. I've commented on that here

prerender.io pricing look a bit expensive, and I think we'll definitely overpass free tier plan.

I would use prerender for most critical pages for SEO engines as they can do one thing well. For collections states we will stick with our existing

when we use nuxt3 and enable ssr mode we dont need prerendering stuff. so we can drop prerendering worker stuff

Is this... for real true? That's like we are at 99% of the race till the finish...

so making this p1 again as we are suffering a lot from not being indexed 😅

Ref

@yangwao yangwao added p1 preventing everyone from using app pre-render and removed p4 affecting less than 10% of app labels Jun 23, 2023
@yangwao yangwao added p3 non-core, affecting less than 40% and removed p1 preventing everyone from using app labels Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-seo-search-socials p3 non-core, affecting less than 40% pre-render
Projects
None yet
Development

No branches or pull requests

3 participants