Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 new cool submit button #6071

Merged
merged 1 commit into from
May 22, 2023
Merged

🎨 new cool submit button #6071

merged 1 commit into from
May 22, 2023

Conversation

vikiival
Copy link
Member

@vikiival vikiival commented May 22, 2023 •
edited by ghost
Loading

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

  • ref kodadot/ideas#31
  • Requires deployment <snek/rubick/worker>

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
Screenshot 2023-05-22 at 20 03 15 Screenshot 2023-05-22 at 20 02 54

Copilot Summary

🤖 Generated by Copilot at effc2a2

Refactored SubmitButton component to use new brick library and TypeScript. Simplified code with script setup syntax.

🤖 Generated by Copilot at effc2a2

We're sailing on the Vue with TypeScript in tow
We've swapped out Buefy for NeoField and NeoButton so
On the count of three we'll pull the script setup line
And hoist the @kodadot1/brick flag to shine

@vikiival vikiival requested a review from a team as a code owner May 22, 2023 18:05
@vikiival vikiival requested review from roiLeo and daiagi and removed request for a team May 22, 2023 18:05
@netlify
Copy link

netlify bot commented May 22, 2023 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit effc2a2
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/646baf07defc290008ed9cf0
😎 Deploy Preview https://deploy-preview-6071--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels May 22, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented May 22, 2023

AI-Generated Summary: This pull request updates the SubmitButton component by replacing b-field and b-button with their Neo counterparts, NeoField and NeoButton, from the @kodadot1/brick package. It also includes necessary import statements for the new components.

@reviewpad
Copy link
Contributor

reviewpad bot commented May 22, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@codeclimate
Copy link

codeclimate bot commented May 22, 2023

Code Climate has analyzed commit effc2a2 and detected 0 issues on this pull request.

View more on Code Climate.

roiLeo
roiLeo approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👁️👄👁️

@daiagi daiagi added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved and removed waiting-for-review labels May 22, 2023
@vikiival vikiival merged commit 40603b6 into main May 22, 2023
@vikiival vikiival deleted the neo-submit-button branch May 22, 2023 19:52
@roiLeo roiLeo mentioned this pull request May 23, 2023
Merged
2 tasks
This was referenced May 25, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roiLeo roiLeo roiLeo approved these changes

@daiagi daiagi daiagi approved these changes

Assignees
No one assigned
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved small Pull request is small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vikiival @roiLeo @daiagi