Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

empty resources on this nft #265

Open
preschian opened this issue Aug 10, 2023 · 10 comments
Open

empty resources on this nft #265

preschian opened this issue Aug 10, 2023 · 10 comments

Comments

@preschian
Copy link
Member

          > can you check? [deploy-preview-6599--koda-canary.netlify.app/ksm/gallery/15635794-54bbd380dc3baaa27b-EVRLOOT-ADVANCED_FISHINGROD-2](https://deploy-preview-6599--koda-canary.netlify.app/ksm/gallery/15635794-54bbd380dc3baaa27b-EVRLOOT-ADVANCED_FISHINGROD-2)

I can only fix the "More from this collection" section

for this specific nft seems like from the indexer side. on rmrk2 at least need some resources. this nft meta.image and resources was empty
image

Originally posted by @preschian in kodadot/nft-gallery#6599 (comment)

@vikiival
Copy link
Member

Hello, can you please rephrase your question? Or provide more context?

@preschian
Copy link
Member Author

Hello, can you please rephrase your question? Or provide more context?

hi @vikiival, how to get the image for this item https://canary.kodadot.xyz/ksm/gallery/15635794-54bbd380dc3baaa27b-EVRLOOT-ADVANCED_FISHINGROD-2
there is no meta.image or resources from the indexer

return null and empty []

@preschian
Copy link
Member Author

Another item in the same collection we can get the resources

image

@vikiival
Copy link
Member

vikiival commented Aug 10, 2023

{
  "data": {
    "token": {
      "id": "15635794-54bbd380dc3baaa27b-EVRLOOT-ADVANCED_FISHINGROD-2",
      "metadata_name": "Reinforced Palm Rod",
      "rootowner": "EVRLT14nteG7mp31N4cmTTpYdDnjxEr25zQwXKC3Suph6L2",
      "resources": [],
      "equipped": null
    }
  }
}

Hello, this is not an issue of our indexer, I checked against RMRK Prod API and NFT does not contain any resources

@preschian
Copy link
Member Author

I see, so it was expected then

do we need to adjust our UI? maybe tell the user "Media not found for this item"

@vikiival
Copy link
Member

anyway, when I search "Reinforced Palm Rod" on singular they show only "439 results"

Yes because they hide some items

https://singular.app/collectibles/kusama/54bbd380dc3baaa27b-EVRLOOT/14983235-54bbd380dc3baaa27b-EVRLOOT-ADVANCED_FISHINGROD-00003220

We have 4/5 cards like this

Screenshot 2023-08-10 at 13 40 53

@preschian
Copy link
Member Author

how to hide it in our query? currently this is our query where: {burned_eq: false, AND: $search}
seems like it's better if we can hide it

without query, the total items in that collection:
singular -> 4314 items
our UI -> 4360 items

@vikiival
Copy link
Member

how to hide it in our query? currently this is our query where: {burned_eq: false, AND: $search} seems like it's better if we can hide it

as the smart man (@preschian) said:

there is no meta.image or resources from the indexer

{
  "data": {
    "nftEntityById": {
      "meta": {
        "name": "Reinforced Palm Rod",
        "image": null,
        "animationUrl": null
      }
    }
  }
}

So dumb approach is to hide it on frontend,
Numbers won't be 100% correct
Till fetching via TokenEntity is not implemented

@preschian
Copy link
Member Author

ok, I think it's better to wait TokenEntity implemented then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants