Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix $size predicate failing when applied to undefined array #313

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

eldaranne
Copy link
Contributor

When testing a query containing fieldName: {$size: 1} on a JSON where fieldName is undefined, it fails because of undefined dereferencing of the array.

@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #313 (4d4129c) into master (8779240) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #313   +/-   ##
=======================================
  Coverage   98.97%   98.97%           
=======================================
  Files         263      263           
  Lines        3625     3625           
  Branches      800      801    +1     
=======================================
  Hits         3588     3588           
  Misses         30       30           
  Partials        7        7           
Impacted Files Coverage Δ
src/operators/_predicates.ts 98.27% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kofrasa kofrasa merged commit e9219e6 into kofrasa:master Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants