Prevent editor toolbar being too small, at least for left-aligned elements #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kossebau
force-pushed
the
fixTooSmallToolbarALittle
branch
from
8944b2f
to
c684c80
Compare
|
Build succeeded. |
|
Build succeeded. |
kossebau
force-pushed
the
fixTooSmallToolbarALittle
branch
from
c684c80
to
401de20
Compare
|
Build succeeded. |
|
The original bug in master is much more subtle on Windows than Aditya's video shows. I can only just see it in IE + FF. But, I can confirm this improves things for me 👍. Please land our first patch of 2015 😄 |
…ments If there are only floating elements, the Dojo toolbar shrinks to 0 height. To prevent this for left-aligned elements, do not set them as float:left. (Also reorder generation to keep current tool ordering) And for elements floating to the right, clear any floating for the toolbar element with "clear:both" on the pseudo :after element.
kossebau
force-pushed
the
fixTooSmallToolbarALittle
branch
from
401de20
to
c29f77c
Compare
|
Thanks for checking :) Landing now at least as second for 2015 :) |
|
Build succeeded. |
kossebau
pushed a commit
that referenced
this pull request
Jan 5, 2015
Prevent editor toolbar being too small, at least for left-aligned elements
|
hups, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are only floating elements, the Dojo toolbar shrinks to 0 height.
To prevent this at least for left-aligned elements, do not set them as
float:left. (Also reorder generation to keep current tool ordering)
No idea yet how to solve supporting right-aligned toolbar elements, whichseem only possible with float:right styling. So if alone on the toolbar,
or if being the first element moved to a new line on shrinked toolbar width,
then still the toolbar is rendered too small.
Using "clear:both" on the :after pseudo element should fix the problem with right floats.
Tested with Firefox 34 and Chromium 39.
Fixes #468 for me.