-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please remove nekohtml classes from your project #22
Comments
It causes much more problems, like incompatibilities with actual neko html on the class path but in different versions and then depending on class path ordering things happen to work or fail and so on. |
Please provide an example how a relocated package interferes with the actual nekohtml. I see that this bug has been open for a while without other comments, perhaps it's not a widespread problem? Ideally, please provide a patch to fix it the way how you see it work best. This way, we can narrow down the issue, even if the actual fix that gets mainlined may differ. The reason why we packaged nekohtml with boilerpipe was that there were upstream bugs in nekohtml that needed fixing, and there was a chance that these fixes would either be overridden by someone's nekohtml version on the classpath, or cause other problems down the road in other apps on the classpath. |
The problem is, that the classes are not relocated, just repackaged into your jar, at least in case of the one on Maven Central. If you would have relocated them, there would be less a problem. Why you don't get more complaints I can only guess. Possible reasons:
|
Thanks for your comment. I wasn't able to touch this library for a while but I may look into that at some point. However, like with many open source projects run by individuals, it's a matter of prioritization. In the meantime, please see if your problem persists with the code from this repository's main branch and, ideally, provide a pull request. This will speed up things. |
Frankly I don't even remember if I used boilerpipe back then :) Judging by the description of the library I think ended up using jsoup. |
Could you please remove nekohtml classes from your project ? Those should be referenced through dependency, not included into your jar directly. It causes problems when someone tries to build monolithic jar of his project.
Thanks.
The text was updated successfully, but these errors were encountered: