Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fabs support for Kokkos::complex and half_t #1206

Open
e10harvey opened this issue Nov 29, 2021 · 0 comments
Open

Add fabs support for Kokkos::complex and half_t #1206

e10harvey opened this issue Nov 29, 2021 · 0 comments

Comments

@e10harvey
Copy link
Contributor

e10harvey commented Nov 29, 2021 •
edited
Loading

#1172 shows a overload resolution conflict in examples/gmres. While resolving this conflict in #1197, we found that Kokkos::Experimental::fabs(double) from KokkosCore conflicts with std::fabs(double). This issue is to:

  1. Determine and document proper Kokkos fabs usage
  2. Determine whether half_t and Kokkos::complex fabs support should reside in ArithTraits or KokkosCore
  3. Add support for fabs(const Kokkos::complex<T> &x) and fabs(half_t) to Kokkos

CC: @lucbv, @jennloe

Related to #1208 and #1197.
@e10harvey e10harvey changed the title Add support for Kokkos::complex and half_t Add fabs support for Kokkos::complex and half_t Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@e10harvey