Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KokkosKernels Trilinos Integration #42

Closed
mndevec opened this issue Aug 4, 2017 · 4 comments
Closed

KokkosKernels Trilinos Integration #42

mndevec opened this issue Aug 4, 2017 · 4 comments

Comments

@mndevec
Copy link
Contributor

mndevec commented Aug 4, 2017

This issue is for the kokkoskernels integration into trilinos.

After commits :
77a2fde and f9b1559
cmake files should be ready to configure and compile "only" kokkoskernels in trilinos.

Next steps are to adapt the changes in the namespaces and filenames to rest of trilinos that uses kokkoskernels directly. To my knowledge, we have ifpack2 and tpetra that use kokkoskernels directly. Please extend this list if there are more packages.

For changes to be done in Trilinos, I created the branch:
https://github.com/mndevec/Trilinos/tree/kk_integration

@mndevec
Copy link
Contributor Author

mndevec commented Aug 4, 2017

I made changes to Tpetra and Ifpack2 files in https://github.com/mndevec/Trilinos/tree/kk_integration

Tpetra multivector compilation was failing because of the issue:
kokkos/kokkos#594

I turned off the static asserts in Kokkos to pass through that step. Other than that Ifpack2 and Trilinos compiled fine on my workstation (gcc-5.1.0). However, multivector tests fails. Hopefully this will go away with this issue.

Another issue is: Tpetra multivector was using Impl:SquareRootFunctor which was functor in KokkosBlas Impl namespace. The file was removed after files are restructured.
I put back the functor to KokkosKernels_Utils.hpp for now.

@mhoemmen
Copy link
Contributor

mhoemmen commented Aug 6, 2017

@mndevec If you need to move Impl::SquareRootFunctor to Tpetra, please feel free to do so.

@mndevec
Copy link
Contributor Author

mndevec commented Aug 8, 2017

Mark, for now I think we will leave it in the current way. It will be better to remove such dependencies in Tpetra in future. I opened the related issue in Trilinos repo.

@mndevec
Copy link
Contributor Author

mndevec commented Aug 8, 2017

The compilation issues for the layoutleft/right conversions for rank=0 views are solved after Kokkos update: kokkos/kokkos#594 (comment)

On my workstation some multivector tests are still failing because of very tight tolerance rations, as below.
These tests are not reported in CDASH, and they also fail without Kokkoskernels commits.
I will not be worried about those until the kokkoskernels integration tests are run.

norms[col] = 2.22507385850720138e-308 == 0.00000000000000000e+00 : FAILED ==>
/packages/tpetra/core/test/MultiVectorFiller/MultiVectorFiller2.cpp:354

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants