Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KokkosBlas::dot only uses cuBLAS with CudaSpace, not with CudaUVMSpace #440

Open
mhoemmen opened this issue Jun 24, 2019 · 3 comments
Open

Comments

@mhoemmen
Copy link
Contributor

KOKKOSBLAS1_DOT_TPL_SPEC_AVAIL_CUBLAS( double, Kokkos::LayoutLeft, Kokkos::CudaSpace)

@kyungjoo-kim @jjellio

@mhoemmen
Copy link
Contributor Author

See #397 .

@jjellio
Copy link

jjellio commented Jun 25, 2019

Its worth pointing that dot via kokkos is faster than the the library calls in most cases I've seen. I imagine the reason is that that is effectively a bandwidth race and the extra indirection of a library call introduces a tiny penalty. Perhaps, it would be better to provide CMake options that allow users to override the default choice. And leave the default as calling Kokkos Kernels. Atleast that way it is explicitly stated when Kokkos is used vs TPL, and provides a mechanism to change it.

@mhoemmen
Copy link
Contributor Author

PLEASE NO MORE CMAKE OPTIONS PLEASE

If KokkosBlas::dot is faster than we should call it. If it's not faster, then we should fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants