Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

supernodal does not build with UVM enabled #633

Closed
jjwilke opened this issue Mar 3, 2020 · 6 comments
Closed

supernodal does not build with UVM enabled #633

jjwilke opened this issue Mar 3, 2020 · 6 comments
Assignees
Milestone

Comments

@jjwilke
Copy link
Contributor

jjwilke commented Mar 3, 2020

If Kokkos is built with UVM enabled, the supernodal build fails with several static asserts about invalid conversions, e.g.

static assertion failed with "View assignment must have compatible spaces"
src/sparse/impl/KokkosSparse_sptrsv_solve_impl.hpp(2586)
  Kokkos::View<scalar_t*, memory_space> work = thandle.get_workspace ();

This does not occur on Cuda builds without UVM or OpenMP builds.

@ndellingwood
Copy link
Contributor

Does replacing
Kokkos::View<scalar_t*, memory_space> work = thandle.get_workspace ();
with
auto work = thandle.get_workspace ();
fix this?

@jjwilke
Copy link
Contributor Author

jjwilke commented Mar 4, 2020

No, I started to get more conversion errors in other places and gave up : )

@jjwilke jjwilke added this to the 3.1 Release milestone Mar 10, 2020
@ndellingwood
Copy link
Contributor

@iyamazaki was this fixed with your updates in PR #675 or #676? I think you had addressed this but I lost track of which PR.

@iyamazaki
Copy link
Contributor

Hi, @nellingwood. No, it has not. But, I am working with @e10harvey to integrate the KK interface for TRMM and TRTRI, and that PR should fix this.

@ndellingwood
Copy link
Contributor

Thanks @iyamazaki ! Wasn't trying to rush you, I mistakenly thought this was part of a different PR.

@ndellingwood
Copy link
Contributor

Marked as In Develop based on merge of #680, thanks @iyamazaki !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants