-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CudaUVMSpace specializations for cuBLAS IAMAX and SCAL #758
Comments
Oh man, why do they need UVM when I am trying to remove it in other places. |
That's for ETI? Because what else would be the specialization? |
It is for cuBLAS TPL. Kokkos-kernels' IAMAX and SCAL have no CudaUVMSpace specializations when calling cuBLAS TPL. We only have CudaSpace specializations. For example:
When CudaUVMSpace is used, the fall-back implementations would be called, which might be slower than cuBLAS. |
why isn't this type-erased before it this that (i.e. use Device<Cuda,AnonymousSpace>)? |
As pointed by @ndellingwood, there is an open issue #144 about AnonymousSpace but it was backlogged. I feel it is somehow beyond the scope of my PR. But should using AnonymousSpace be reprioritized? @srajama1 @crtrott |
yeah its fine not to do it in your PR. but generally it might be worthwhile to look at that. |
Thanks @crtrott |
I will look at that. |
Requested by GEMMA for integrating GEMMA and ADELUS.
The text was updated successfully, but these errors were encountered: