Kokkos version in cpp define

[ambrad]

I don't think Kokkos currently has a C preprocessor define for version, like #define KOKKOS_VERSION 3001. This would be helpful in the following situation. Application A depends on library B and Kokkos K1. K1 is outdated relative to Kokkos master K2, and B has to support both A and other applications, which perhaps are now using K2. Thus, B's code must be able to build against both K1 and K2. A KOKKOS_VERSION would be useful in this situation. I'm aware that recent CMake changes in Kokkos export some version data, but it's not clear to me that B always will be able to access that data when it's embedded in other apps. In contrast, a KOKKOS_VERSION define exported in KokkosCore_config.h (say), would solve the problem cleanly.

[oksanaguba]

Can I add a request to have SHA recorded in the build?

[dalg24]

Can I add a request to have SHA recorded in the build?

Yes we will do that as well.

[crtrott]

I don't know. It means we need to have a dependency on git, which kills the tarball downloads from github? And sometimes those are very useful to get stuff on machines which can't talk to the open world.