Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic network configuration: Provide Horizon URL and Network Passphrase #352

Closed
4 tasks done
miguelnietoa opened this issue Feb 29, 2024 · 1 comment
Closed
4 tasks done

Comments

@miguelnietoa
Copy link
Member

miguelnietoa commented Feb 29, 2024

Context

The current approach of setting the network via application environments in the Stellar SDK needs to be revised due to the inability to support functionalities similar to Stellar Laboratory where switching between different networks is required.

image

Current approach is:

config :stellar_sdk, network: :test

Objective

Remove the network configuration from the envs application, and rather provide the Horizon URL and Network Passphrase.

Checklist

Horizon

  • Create a Stellar.Horizon.Server module.
  • Receive a Stellar.Horizon.Server struct in every module inside the Horizon boundary.

TxBuild

  • Receive the network_passphase in the TxBuild struct.
  • Update the Stellar.Network module to expose the passphases of each network.
@miguelnietoa
Copy link
Member Author

These changes have been implemented and are available in v0.21.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@miguelnietoa and others