Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the generated Svelte types for
Button
andLink
. Currently, the types don't allow for native HTML attributes. For example, VS Code complains abouthref
onLink
, andvalue
onButton
:Similarly,
svelte-check --tsconfig ./tsconfig.json
fails:I fixed the
Link
andButton
by using Svelte's typing for it. I first manually fixed the generated types until the lint errors were quieted, and then changed the type generation code to match my manual changes.There may be other elements that require a similar fix since I didn't exhaustively search for similar cases, and instead only fixed the cases I encountered. However, it should be easy to update additional elements if need be.
konsta
versions 3.1.4 and 4.0.0.svelte
version 4.2.18.svelte-check
version 3.8.5.@tsconfig/svelte
version 5.0.4.