Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Azure DNS resource group is an optional parameter #2330

Closed
5 of 6 tasks
mrsimonemms opened this issue Nov 26, 2024 · 2 comments
Closed
5 of 6 tasks

Make Azure DNS resource group is an optional parameter #2330

mrsimonemms opened this issue Nov 26, 2024 · 2 comments
Assignees
Labels
feature Something new

Comments

@mrsimonemms
Copy link
Contributor

mrsimonemms commented Nov 26, 2024

What is your feature idea?

The Golang SDK for Azure implied that the DNS zone needed a resource group to be found. The Terraform docs (which uses the Azure SDK) have it as an optional field.

See if we can do the same

Why is it needed?

Reduce input variables/complexity

Is this missing feature preventing you from using kubefirst?

  • Yes

Code of Conduct

  • I agree to follow this project's Code of Conduct

Tasks

@mrsimonemms mrsimonemms added the feature Something new label Nov 26, 2024
@mrsimonemms mrsimonemms self-assigned this Nov 26, 2024
Copy link

linear bot commented Nov 26, 2024

@mrsimonemms
Copy link
Contributor Author

mrsimonemms commented Nov 26, 2024

My guess is that Terraform searches for a list of resource groups and then searches for the domain name in each one, stopping after the first true. I did look at this originally and I think the resource group was a reasonably slow API call, but some time-boxed investigation won't hurt.

If this is the case, this will require changes to the CLI, API and the required fields in the Console installer.

@mrsimonemms mrsimonemms changed the title Investigate if Azure DNS resource group name is actually required Make Azure DNS resource group is an optional parameter Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Something new
Projects
None yet
Development

No branches or pull requests

1 participant