-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve template download logic #757
Comments
implemented |
Fixed the logic above on Release, to support people using LDflags to run using the gitops branch for "non-dev" mode as regular release similar to the way it work for the clouds.
Builds with LDFLAGS set should also allow clone from branch. So, AC rules above should suppoort that. AC X: Support |
Fix in the code provided at: #818 |
This mode should run an respect the flag to of gitops-branch if is provided, the branch should be cloned, not the tag: go build -ldflags="-X github.com/kubefirst/kubefirst/configs.K1Version=1.10.11" .
./kubefirst local --gitops-branch add-ingress-localhost |
The exiting implementation was preventing, developers that use the |
In order to simplify the logic to download the correct template based on the release, as a Kubefirst user I want to have the following logic to select the current template version:
AC1: we unsure it works as expected for local development on (local, cloud github and cloud aws)
AC2: the logic works for local development using
go run
and using the binary/built versionThe text was updated successfully, but these errors were encountered: