Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify IPropertyValueConverter #219

Open
petrsvihlik opened this issue Jun 2, 2020 · 0 comments
Open

Simplify IPropertyValueConverter #219

petrsvihlik opened this issue Jun 2, 2020 · 0 comments
Labels
blocked refactoring

Comments

@petrsvihlik
Copy link
Contributor

petrsvihlik commented Jun 2, 2020 •
edited
Loading

Blocked by: #215

Motivation

Both Newtonsoft.Json and System.Text.Json support value converters. We could get rid of our custom implementation based on the IPropertyValueConverter. It would be one thing less to learn for the consumers of our SDK + we'd reduce the codebase.

Newtonsoft.Json

System.Text.Json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@petrsvihlik