Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [RULES] False positive on hibernate annotation rules hibernate-search-00750, hibernate-search-00800 and hibernate-search-00980 #653

Open
1 task done
abrugaro opened this issue Jul 12, 2024 · 1 comment
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Milestone

Comments

@abrugaro
Copy link
Contributor

abrugaro commented Jul 12, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Konveyor version

0.5 beta 1

Priority

Undefined (Default)

Anything else?

Tested with Kantra b0.5 beta1
Target: eap8 (and others)
Source: none
Source code used: https://github.com/sonatype/nexus-public
Rules triggered:

  • hibernate-search-00980 The @factory annotation is not available anymore
  • hibernate-search-00800 The @key annotation is not available anymore
  • hibernate-search-00750The @field(s) annotation has been split into multiple annotations

Report: https://drive.google.com/file/d/1TbdLS4_728DgxbB88F7YcXw84jK2elty/view?usp=drive_link

These 3 rules are supposed to match deprecated or updated annotations for Hibernate Entities, however the reported a combination of 40 incidents where the majority of them do not belong to annotation but other elements (methods, classes, etc), and those elements do not even belong to Hibernate.

image
image
image
image

@abrugaro abrugaro added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 12, 2024
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added the needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. label Jul 12, 2024
@dymurray dymurray added this to the v0.5.0 milestone Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

2 participants