Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update design of perspective selector above nav to match new PF demo structure #1187

Open
mturley opened this issue Jul 21, 2023 · 1 comment
Open

Update design of perspective selector above nav to match new PF demo structure #1187

mturley opened this issue Jul 21, 2023 · 1 comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/minor Lowest priority. Possibly useful, but not yet enough support to actually get it done. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@mturley
Copy link
Collaborator

mturley commented Jul 21, 2023 •
edited
Loading

See conversation in Slack: https://patternfly.slack.com/archives/C4FM977N0/p1689958298525549?thread_ts=1689955946.931889&cid=C4FM977N0

This would be a followup to #1163 and #1185 and remove the custom CSS in SidebarApp.css needed for the current design.

It appears we need to wait for some PF changes to fully support this via React components, but the structure can be seen in an HTML example here: https://pf5.patternfly.org/components/menus/context-selector/html-demos/context-selector-in-sidebar/

Old and busted:

Screenshot 2023-07-21 at 12 07 14 PM

New hotness:

Screenshot 2023-07-21 at 1 05 20 PM
@mturley
Copy link
Collaborator Author

mturley commented Jul 21, 2023

See related issue: patternfly/patternfly#5776

@sjd78 sjd78 added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/minor Lowest priority. Possibly useful, but not yet enough support to actually get it done. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jul 18, 2024
@sjd78 sjd78 added this to Planning Jul 18, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Planning Jul 18, 2024
@sjd78 sjd78 moved this from 🆕 New to 📋 Backlog in Planning Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/minor Lowest priority. Possibly useful, but not yet enough support to actually get it done. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Planning
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mturley @sjd78