Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Convert sorting to localeNumericCompare() across the app #1824

Open
1 task done
ibolton336 opened this issue Apr 5, 2024 · 4 comments
Open
1 task done

[BUG] Convert sorting to localeNumericCompare() across the app #1824

ibolton336 opened this issue Apr 5, 2024 · 4 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@ibolton336
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Konveyor version

latest

Priority

Critical

Current Behavior

The function localeNumericCompare() has proven to be a valuable utility for comparing strings numerically in a way that respects locale-specific ordering.

This issue is to cover standardizing its usage across the application

Expected Behavior

No response

How Reproducible

Always (Default)

Steps To Reproduce

No response

Environment

- OS:

Anything else?

No response
@ibolton336 ibolton336 added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 5, 2024
@ibolton336 ibolton336 changed the title [BUG] <title> [BUG] Convert sorting to localeNumericCompare() across the app Apr 5, 2024
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added the needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. label Apr 5, 2024
@ibolton336 ibolton336 mentioned this issue Apr 5, 2024
Merged
@ibolton336 ibolton336 added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. approved and removed needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 5, 2024
@konveyor-ci-bot konveyor-ci-bot bot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Apr 5, 2024
@konveyor-ci-bot
Copy link

This issue has been marked 'good first issue'
Please, make sure it aligns with the criteria found here

@sjd78
Copy link
Member

sjd78 commented Jun 6, 2024

@rszwajko - Did your natural sort ordering PR also take care of this issue?

@sjd78 sjd78 added triage/needs-information Indicates an issue needs more information in order to work on it. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. approved needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Jun 6, 2024
@konveyor-ci-bot konveyor-ci-bot bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jun 6, 2024
@rszwajko
Copy link
Collaborator

rszwajko commented Jun 6, 2024

@rszwajko - Did your natural sort ordering PR also take care of this issue?

No. The selectionOptions need to be explicitly sorted - in the same way we do it for tag categories here ->

tackle2-ui/client/src/app/pages/applications/components/application-tags/application-tags.tsx

Line 151 in 56e556f

.sort(universalComparator)

@sjd78 sjd78 added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed triage/needs-information Indicates an issue needs more information in order to work on it. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Planning
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sjd78 @ibolton336 @rszwajko