Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List conflicts - label + classify conflicts #84

Merged
merged 1 commit into from
May 18, 2020
Merged

Conversation

olsen232
Copy link
Collaborator

The beginnings of a (not yet existent) command to list all conflicts, in a format of your choice. So far, still only supports showing summaries of conflicts, but classifying conflicts and naming conflicts is much more rigorous. Summarising conflicts can now use the same code that will generate full diffs of conflicts, so naming and categorising will be consistent.

Output of sno merge is now switched to use this new code.

@olsen232 olsen232 requested review from rcoup and craigds May 15, 2020 04:31
@olsen232 olsen232 force-pushed the list_conflicts branch 2 times, most recently from 2b5e8cc to 5745e45 Compare May 17, 2020 23:02
Copy link
Member

@craigds craigds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with minor edits, LGTM

sno/conflicts.py Outdated Show resolved Hide resolved
sno/conflicts.py Outdated Show resolved Hide resolved
sno/conflicts.py Outdated Show resolved Hide resolved
sno/structure.py Outdated Show resolved Hide resolved
sno/conflicts.py Outdated Show resolved Hide resolved
@olsen232 olsen232 merged commit efa356d into master May 18, 2020
@olsen232 olsen232 deleted the list_conflicts branch May 18, 2020 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants